-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/#review177065
-----------------------------------------------------------
Master (2cbaeec) is red with this patch.
./build-support/jenkins/build.sh
Running setup.py bdist_wheel for twitter.common.log: finished with status
'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/80/e3/3a/297d8950fcbd822ab5a6a62175818fab38b668cc5a86dbd0b0
Running setup.py bdist_wheel for pycparser: started
Running setup.py bdist_wheel for pycparser: finished with status 'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/a8/0b/41/dc95621f9d3a0da7bc191b8a71f0e8182ffd3cc5f33ac55005
Running setup.py bdist_wheel for twitter.common.options: started
Running setup.py bdist_wheel for twitter.common.options: finished with status
'done'
Stored in directory:
/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/17/41/80/c4811d8c1c7ca7007e520c3399872fc340f45c3a26a6a23e6a
Successfully built pantsbuild.pants twitter.common.collections setproctitle
ansicolors pathspec scandir twitter.common.dirutil psutil pystache docutils
Markdown Pygments twitter.common.confluence coverage lmdb pywatchman
twitter.common.lang twitter.common.log pycparser twitter.common.options
Installing collected packages: twitter.common.lang, twitter.common.collections,
setproctitle, setuptools, six, ansicolors, pyparsing, packaging, pathspec,
scandir, twitter.common.dirutil, psutil, requests, pystache, pex, docutils,
Markdown, Pygments, twitter.common.options, twitter.common.log,
twitter.common.confluence, monotonic, fasteners, coverage, pycparser, cffi,
lmdb, pywatchman, futures, pantsbuild.pants
Found existing installation: setuptools 21.2.1
Uninstalling setuptools-21.2.1:
Successfully uninstalled setuptools-21.2.1
Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cffi-1.7.0
coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89
monotonic-1.3 packaging-16.7 pantsbuild.pants-1.3.0.dev3 pathspec-0.3.4
pex-1.1.16 psutil-4.3.0 pycparser-2.17 pyparsing-2.2.0 pystache-0.5.3
pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10
setuptools-30.0.0 six-1.10.0 twitter.common.collections-0.3.9
twitter.common.confluence-0.3.9 twitter.common.dirutil-0.3.9
twitter.common.lang-0.3.9 twitter.common.log-0.3.9 twitter.common.options-0.3.9
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
18:17:52 00:00 [main]
(To run a reporting server: ./pants server)
18:17:52 00:00 [setup]
18:17:52 00:00 [parse][32m
Executing tasks in goals: compile[0m
18:17:52 00:00 [compile]
18:17:52 00:00 [compile-prep-command]
18:17:52 00:00 [prep_command]
18:17:56 00:04 [compile]
18:17:56 00:04 [python-eval]
18:17:56 00:04 [pythonstyle]
18:17:56 00:04 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
T301:ERROR
src/test/python/apache/aurora/executor/test_thermos_executor.py:401 Expected 1
blank lines, found 0
| def __eq__(self, other):
FAILURE: 1 Python Style issues found. For import order related issues, please
try `./pants fmt.isort <targets>`
18:18:20 00:28 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On June 6, 2017, 5:47 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59733/
> -----------------------------------------------------------
>
> (Updated June 6, 2017, 5:47 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham,
> Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1931
> https://issues.apache.org/jira/browse/AURORA-1931
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We have some services that require more than the current 10 seconds given to
> gracefully shutdown (they need to close resources, finish requests, etc).
>
> We would like to be able to configure the amount of time we wait between each
> stage of the graceful shutdown sequence. See this
> [proposal](https://docs.google.com/document/d/1Sl-KWNyt1j0nIndinqfJsH3pkUY5IYXfGWyLHU2wacs/edit?usp=sharing)
> for a more in-depth
> analysis.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md c73643d669363a56e530c2d8c79d6ea06cc9415b
> docs/reference/task-lifecycle.md cf1b6794dca92756cee4a54f00f33fd3b1a481ea
> src/main/python/apache/aurora/config/schema/base.py
> b2692a648645a195a24491e4978fb833c6c20be8
> src/main/python/apache/aurora/executor/aurora_executor.py
> 81461cb49ac223f3bdfa59e8c59e150a07771dea
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
> c6c08983fb2d204afedd419798135d667169bce4
> src/main/python/apache/aurora/executor/http_lifecycle.py
> 9280bf29da9bda1691adbf3a4c34c4f3d4900517
> src/test/python/apache/aurora/client/cli/test_inspect.py
> 4a23c5984c2d093e2f53e93aec71418f84b65928
>
> src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py
> 38deae69dce7d88dab87f70e0128e0b86091fdef
> src/test/python/apache/aurora/executor/test_http_lifecycle.py
> a967e3410a4d2dc2e1721f505a4d76da9209d177
> src/test/python/apache/aurora/executor/test_thermos_executor.py
> e628ccd21f0588d0c76001b8f336ffa844c3ec35
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py
> 1b92667bceabc8ea1540122477a51cb58ea2ae36
>
>
> Diff: https://reviews.apache.org/r/59733/diff/2/
>
>
> Testing
> -------
>
> Ran unit and integration tests.
>
> Created and killed jobs with varying wait_escalation_secs values on the
> Vagrant devcluster.
>
>
> Thanks,
>
> Jordan Ly
>
>
