----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186349 -----------------------------------------------------------
Fix it, then Ship it! Small naming nit but otherwise LGTM src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java Line 122 (original), 122 (patched) <https://reviews.apache.org/r/62604/#comment262895> I would probably rename `existingTasks` -> `collidingInstances` or something else to show that "these are the instance IDs that already exist but you are trying to add them". - Jordan Ly On Sept. 27, 2017, 12:10 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62604/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 12:10 a.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > Came across this while looking at storage access patterns. Not a > particularly hot code path, but this is more efficient and concise. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 6b780ec90fed846531162eed5e86336e598e33a3 > > > Diff: https://reviews.apache.org/r/62604/diff/1/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
