> On Sept. 26, 2017, 5:22 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > > Line 122 (original), 122 (patched) > > <https://reviews.apache.org/r/62604/diff/1/?file=1836412#file1836412line123> > > > > I would probably rename `existingTasks` -> `collidingInstances` or > > something else to show that "these are the instance IDs that already exist > > but you are trying to add them". > > Jordan Ly wrote: > Oops made it an issue, but since it is a nit it is more personal > preference. Obviously feel free to drop if you feel the name is > concise/informative enough.
I hear you. I went with the more concise `collision` in the same vein; feel free to veto. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186349 ----------------------------------------------------------- On Sept. 26, 2017, 5:10 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62604/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 5:10 p.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > Came across this while looking at storage access patterns. Not a > particularly hot code path, but this is more efficient and concise. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 6b780ec90fed846531162eed5e86336e598e33a3 > > > Diff: https://reviews.apache.org/r/62604/diff/1/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
