> On Sept. 27, 2017, 4:28 p.m., Joshua Cohen wrote: > > FWIW there's also a version of React 15 that's been licensed under MIT: > > https://facebook.github.io/react/blog/2017/09/25/react-v15.6.2.html
Ah, good to know. I think this is the correct approach anyway. Reactable would eventually block us from upgrading if we wanted to use some other new library. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62607/#review186425 ----------------------------------------------------------- On Sept. 27, 2017, 3:04 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62607/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 3:04 p.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Replace Preact and custom testing with React + jest + Enzyme now that they > are MIT licensed. > > Side-effects: > > * The Reactable library is not compatible with React 16.0 (the MIT licensed > version we are forced to use) and attempts to flag this started as early as > June this year. But the author seems to have abandoned the library. So I had > to create my own Pagination class. I found myself repeatedly using Reactable > in places where I just wanted pagination (for lists of divs) anyway, so maybe > this is a good thing. > * Deleted custom (and questionable) shallow renderer. > * The download time will be reduced due to not having to download PhantomJS. > > > Diffs > ----- > > ui/karma.conf.js d42cda7d025f8c5618039888f4fb49ff388c3af1 > ui/package.json d6802029e0aeb9f6692ec8cc065949ce17b2ca07 > ui/src/__mocks__/react.js PRE-CREATION > ui/src/main/js/components/Pagination.js PRE-CREATION > ui/src/main/js/components/RoleList.js > 32595601aae06730f537d37d95be2e746f779103 > ui/src/main/js/components/__tests__/Breadcrumb-test.js > 18af0fe6c360f375fb0fa1694304d821041d9e16 > ui/src/main/js/components/__tests__/Home-test.js > 8e6bc09050148ea9711dbfe6f52b83c8210262be > ui/src/main/js/components/__tests__/Pagination-test.js PRE-CREATION > ui/src/main/js/pages/__tests__/Home-test.js > 4f13f99ea24c0252b5f6cbb6980e0c96832d5120 > ui/src/main/js/utils/ShallowRender.js > 52e8bb259264e7dd47ee97cec35553acc147e818 > ui/src/main/js/utils/__tests__/ShallowRender-test.js > d5663a7c44de795a5aa0b28d4f373871ffcc3fd2 > ui/src/main/sass/components/_tables.scss > 58f176cffcdae34de7c776e31b3f0342efa3024f > ui/test-setup.js PRE-CREATION > ui/webpack.config.js e7cd672df62006bd5c5b60a6ba0903e16a767d13 > > > Diff: https://reviews.apache.org/r/62607/diff/1/ > > > Testing > ------- > > Unfortunately the Gradle 4.2 upgrade seems to have broken running builds from > gradle (will attempt to fix in another ticket)... So I had to manually verify > with: > > $ npm run lint > $ npm test > > I also tested the UI in my Vagrant image. > > > Thanks, > > David McLaughlin > >
