> On Sept. 27, 2017, 9:08 a.m., Bill Farner wrote: > > > Unfortunately the Gradle 4.2 upgrade seems to have broken running builds > > > from gradle > > > > I didn't witness 4.2 causing breakage, but did find other issues, patched > > at [62620](https://reviews.apache.org/r/62620/). I'll be curious what's > > going on if that fix your setup as well. > > David McLaughlin wrote: > To be clear: it doesn't break the build. But ./gradlew ui:test and > ./gradlew ui:lint were giving false positives and then were marked as > UP-TO-DATE even after changing the sources. > > David McLaughlin wrote: > It looks like the gradle-node-plugin isn't working with 4.1: > > https://github.com/srs/gradle-node-plugin/issues/251 > > And there isn't a lot of support. I don't have the bandwidth to look into > the plugin. Was there a motivation for upgrading gradle to such a recent > version? (4.2 was just released AFAICT)
I upgraded to get JDK 9 support (introduced in 4.1). However, there isn't urgency to this. Reverting to 4.0.2 should be fine if that addresses the issues. Otherwise, i'd like to be >= 3.4 to keep the jacoco coverage check introduced. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62607/#review186421 ----------------------------------------------------------- On Sept. 27, 2017, 9:50 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62607/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 9:50 a.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Replace Preact and custom testing with React + jest + Enzyme now that they > are MIT licensed. > > Side-effects: > > * The Reactable library is not compatible with React 16.0 (the MIT licensed > version we are forced to use) and attempts to flag this started as early as > June this year. But the author seems to have abandoned the library. So I had > to create my own Pagination class. I found myself repeatedly using Reactable > in places where I just wanted pagination (for lists of divs) anyway, so maybe > this is a good thing. > * Deleted custom (and questionable) shallow renderer. > * The download time will be reduced due to not having to download PhantomJS. > > > Diffs > ----- > > ui/karma.conf.js d42cda7d025f8c5618039888f4fb49ff388c3af1 > ui/package.json d6802029e0aeb9f6692ec8cc065949ce17b2ca07 > ui/src/__mocks__/react.js PRE-CREATION > ui/src/main/js/components/Pagination.js PRE-CREATION > ui/src/main/js/components/RoleList.js > 32595601aae06730f537d37d95be2e746f779103 > ui/src/main/js/components/__tests__/Breadcrumb-test.js > 18af0fe6c360f375fb0fa1694304d821041d9e16 > ui/src/main/js/components/__tests__/Home-test.js > 8e6bc09050148ea9711dbfe6f52b83c8210262be > ui/src/main/js/components/__tests__/Pagination-test.js PRE-CREATION > ui/src/main/js/pages/__tests__/Home-test.js > 4f13f99ea24c0252b5f6cbb6980e0c96832d5120 > ui/src/main/js/utils/ShallowRender.js > 52e8bb259264e7dd47ee97cec35553acc147e818 > ui/src/main/js/utils/__tests__/ShallowRender-test.js > d5663a7c44de795a5aa0b28d4f373871ffcc3fd2 > ui/src/main/sass/components/_tables.scss > 58f176cffcdae34de7c776e31b3f0342efa3024f > ui/test-setup.js PRE-CREATION > ui/webpack.config.js e7cd672df62006bd5c5b60a6ba0903e16a767d13 > > > Diff: https://reviews.apache.org/r/62607/diff/2/ > > > Testing > ------- > > Unfortunately the Gradle 4.2 upgrade seems to have broken running builds from > gradle (will attempt to fix in another ticket)... So I had to manually verify > with: > > $ npm run lint > $ npm test > > I also tested the UI in my Vagrant image. > > > Thanks, > > David McLaughlin > >
