> On Sept. 27, 2017, 8:33 p.m., Reza Motamedi wrote: > > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > > Line 109 (original), 109 (patched) > > <https://reviews.apache.org/r/62626/diff/1/?file=1837865#file1837865line109> > > > > Is just testing shutdown of the leader? Should we have separate tests > > the followers then?
I believe this is just testing the expectations around shutdowns in `SchedulerLifecycle.java`. This method specifically expects everything in `shutdown()` as well as that the leader leaves the control. Followers should just be able to use `shutdown()`. - Jordan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62626/#review186473 ----------------------------------------------------------- On Sept. 27, 2017, 8:25 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62626/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 8:25 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1950 > https://issues.apache.org/jira/browse/AURORA-1950 > > > Repository: aurora > > > Description > ------- > > Ensure that `SchedulerMain.run()` calls stop in the case of exceptions. This > prevents the Scheduler from being transitioned to DEAD state, but not > actually stopping it's services. > > See the attached ticket for an example of issue happening. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 3fbe99c4f1af1f11403bf08155bb4be028132e38 > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > 70479ef8be324bf2e382b0d2ad594c2eb33c931c > > > Diff: https://reviews.apache.org/r/62626/diff/1/ > > > Testing > ------- > > Added an additional unit test for prepare() failing in > `SchedulerLifecycle.java`. > > ./gradlew test > ./build-support/jenkin/build.sh > > > Thanks, > > Jordan Ly > >
