> On Sept. 27, 2017, 9:45 p.m., Santhosh Kumar Shanmugham wrote: > > Wonder if this will fix the issue with shutting down the Webhooks > > AsyncHttpClient as well?
This should just always call the shutdown sequence when `run()` ends, (ie. `stop()` is always called in the case of errors and etc). Looking at the Webhooks patch, this patch will unfortunately not help. We will need to convert Webhooks into a `Service`, write a suitable `shutdown()` method that closes the AsyncHttpClient, and register the service to be initiated on startup (or leader election, not sure how it works). - Jordan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62626/#review186488 ----------------------------------------------------------- On Sept. 27, 2017, 8:25 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62626/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 8:25 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-1950 > https://issues.apache.org/jira/browse/AURORA-1950 > > > Repository: aurora > > > Description > ------- > > Ensure that `SchedulerMain.run()` calls stop in the case of exceptions. This > prevents the Scheduler from being transitioned to DEAD state, but not > actually stopping it's services. > > See the attached ticket for an example of issue happening. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 3fbe99c4f1af1f11403bf08155bb4be028132e38 > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > 70479ef8be324bf2e382b0d2ad594c2eb33c931c > > > Diff: https://reviews.apache.org/r/62626/diff/1/ > > > Testing > ------- > > Added an additional unit test for prepare() failing in > `SchedulerLifecycle.java`. > > ./gradlew test > ./build-support/jenkin/build.sh > > > Thanks, > > Jordan Ly > >
