----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186900 -----------------------------------------------------------
LGMT. Minor comments. build.gradle Line 85 (original), 85 (patched) <https://reviews.apache.org/r/62700/#comment263785> nit - Make it more specific to the library name - s/httpclientRev/asyncHttpclientRev/ build.gradle Line 86 (original), 86 (patched) <https://reviews.apache.org/r/62700/#comment263778> Remove this unused. src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java Lines 74-76 (original), 75-77 (patched) <https://reviews.apache.org/r/62700/#comment263820> Wonder if we should configure other timeouts as well? Like `readTimeout` etc. https://github.com/AsyncHttpClient/async-http-client/blob/master/client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java#L81-L108 - Santhosh Kumar Shanmugham On Sept. 29, 2017, 5:17 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62700/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2017, 5:17 p.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, > Stephan Erb, and Bill Farner. > > > Bugs: AURORA-1773 > https://issues.apache.org/jira/browse/AURORA-1773 > > > Repository: aurora > > > Description > ------- > > Hijacking https://reviews.apache.org/r/59703 > > From the above review: "Current code uses a synchronous HTTP client, which > can block the EventBus. Switch to an async HTTP client." > > Previously, we had an issue where the HTTP client would have a non-daemon > thread which caused the Scheduler to fail to shutdown. I converted it into an > AbstractIdleService and properly closed the client in the shutdown() method. > Additionally, I made a small tweak to the original code where we ABORT any > response receieved after the status since we don't care. We just use the > response code for stats. > > > Diffs > ----- > > build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > 05f46a1946e062ac57cca828c094586f4c983f45 > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java > da22c218c5fbe6607552edbb4f8e52850d718851 > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java > 1f10af71830386652d21961b733bd0927c5436a1 > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > 07f39fa487e0ebd2252568750d5f36ac200a96aa > > > Diff: https://reviews.apache.org/r/62700/diff/2/ > > > Testing > ------- > > ./gradlew test > > Tested proper shutdown occurs in Vagrant. > Currently scale-testing over the weekend. > > > Thanks, > > Jordan Ly > >
