-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62700/#review186926
-----------------------------------------------------------
Master (6fd6d50) is red with this patch.
./build-support/jenkins/build.sh
[68] ./~/react-dom/cjs/react-dom.development.js 607 kB {0} [built]
[79] ./~/react-router-dom/es/withRouter.js 143 bytes {0} [built]
[86] ./~/react/cjs/react.development.js 55.3 kB {0} [built]
[87] ./~/react/cjs/react.production.min.js 5.61 kB {0} [built]
+ 75 hidden modules
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java:34:8:
Unused import - org.asynchttpclient.Response. [UnusedImports]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 2m 56s
38 actionable tasks: 32 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 3, 2017, 4:25 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62700/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2017, 4:25 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham,
> Stephan Erb, and Bill Farner.
>
>
> Bugs: AURORA-1773
> https://issues.apache.org/jira/browse/AURORA-1773
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hijacking https://reviews.apache.org/r/59703
>
> From the above review: "Current code uses a synchronous HTTP client, which
> can block the EventBus. Switch to an async HTTP client."
>
> Previously, we had an issue where the HTTP client would have a non-daemon
> thread which caused the Scheduler to fail to shutdown. I converted it into an
> AbstractIdleService and properly closed the client in the shutdown() method.
> Additionally, I made a small tweak to the original code where we ABORT any
> response receieved after the status since we don't care. We just use the
> response code for stats.
>
>
> Diffs
> -----
>
> build.gradle f9579a38de95ff9e11cf2e44980d01e103226389
> src/main/java/org/apache/aurora/scheduler/events/Webhook.java
> 05f46a1946e062ac57cca828c094586f4c983f45
> src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java
> da22c218c5fbe6607552edbb4f8e52850d718851
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java
> 1f10af71830386652d21961b733bd0927c5436a1
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java
> 07f39fa487e0ebd2252568750d5f36ac200a96aa
>
>
> Diff: https://reviews.apache.org/r/62700/diff/3/
>
>
> Testing
> -------
>
> ./gradlew test
>
> Tested proper shutdown occurs in Vagrant.
>
> Scale tested up to 2000 TASK_LOST events with the registered endpoint waiting
> 5-10 minutes to response -- does not seem to block scheduling.
>
>
> Thanks,
>
> Jordan Ly
>
>
