----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187031 -----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java Line 47 (original), 54 (patched) <https://reviews.apache.org/r/62700/#comment263986> I believe `extends EasyMockTest` is no longer needed. src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java Lines 112 (patched) <https://reviews.apache.org/r/62700/#comment263985> Slightly more work, but you'll want to use an ephemeral port to avoid conflict. src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java Lines 144 (patched) <https://reviews.apache.org/r/62700/#comment263987> This leaves much to be desired, since it's handling the union of all test cases. Can you instead start the jetty server in each test case, and wire in a very specific handler appropriate for the test? - Bill Farner On Oct. 3, 2017, 5:16 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62700/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2017, 5:16 p.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, > Stephan Erb, and Bill Farner. > > > Bugs: AURORA-1773 > https://issues.apache.org/jira/browse/AURORA-1773 > > > Repository: aurora > > > Description > ------- > > Hijacking https://reviews.apache.org/r/59703 > > From the above review: "Current code uses a synchronous HTTP client, which > can block the EventBus. Switch to an async HTTP client." > > Previously, we had an issue where the HTTP client would have a non-daemon > thread which caused the Scheduler to fail to shutdown. I converted it into an > AbstractIdleService and properly closed the client in the shutdown() method. > Additionally, I made a small tweak to the original code where we ABORT any > response receieved after the status since we don't care. We just use the > response code for stats. > > > Diffs > ----- > > build.gradle 069c62ecfc097a3ff22bcf207b2574dd417b0b15 > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > 05f46a1946e062ac57cca828c094586f4c983f45 > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java > da22c218c5fbe6607552edbb4f8e52850d718851 > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java > 1f10af71830386652d21961b733bd0927c5436a1 > src/main/resources/org/apache/aurora/scheduler/webhook.json > b78c063d0a72d7a22a8806451e4002d27eaf759a > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > 07f39fa487e0ebd2252568750d5f36ac200a96aa > > > Diff: https://reviews.apache.org/r/62700/diff/5/ > > > Testing > ------- > > ./gradlew test > > Tested proper shutdown occurs in Vagrant. > > Scale tested up to 2000 TASK_LOST events with the registered endpoint waiting > 5-10 minutes to response -- does not seem to block scheduling. > > > Thanks, > > Jordan Ly > >
