-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62700/#review187047
-----------------------------------------------------------
Master (4e7cdc4) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test
org.apache.aurora.scheduler.events.WebhookTest >
testTaskChangedWithOldStateSuccess FAILED
java.lang.AssertionError at WebhookTest.java:160
I1004 04:46:59.646 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1144 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated:
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 6m 12s
50 actionable tasks: 41 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 4, 2017, 4:31 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62700/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2017, 4:31 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham,
> Stephan Erb, and Bill Farner.
>
>
> Bugs: AURORA-1773
> https://issues.apache.org/jira/browse/AURORA-1773
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hijacking https://reviews.apache.org/r/59703
>
> From the above review: "Current code uses a synchronous HTTP client, which
> can block the EventBus. Switch to an async HTTP client."
>
> Previously, we had an issue where the HTTP client would have a non-daemon
> thread which caused the Scheduler to fail to shutdown. I converted it into an
> AbstractIdleService and properly closed the client in the shutdown() method.
> Additionally, I made a small tweak to the original code where we ABORT any
> response receieved after the status since we don't care. We just use the
> response code for stats.
>
>
> Diffs
> -----
>
> build.gradle 069c62ecfc097a3ff22bcf207b2574dd417b0b15
> src/main/java/org/apache/aurora/scheduler/events/Webhook.java
> 05f46a1946e062ac57cca828c094586f4c983f45
> src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java
> da22c218c5fbe6607552edbb4f8e52850d718851
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java
> 1f10af71830386652d21961b733bd0927c5436a1
> src/main/resources/org/apache/aurora/scheduler/webhook.json
> b78c063d0a72d7a22a8806451e4002d27eaf759a
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java
> 07f39fa487e0ebd2252568750d5f36ac200a96aa
>
>
> Diff: https://reviews.apache.org/r/62700/diff/6/
>
>
> Testing
> -------
>
> ./gradlew test
>
> Tested proper shutdown occurs in Vagrant.
>
> Scale tested up to 2000 TASK_LOST events with the registered endpoint waiting
> 5-10 minutes to response -- does not seem to block scheduling.
>
>
> Thanks,
>
> Jordan Ly
>
>
