----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62908/#review187721 -----------------------------------------------------------
ui/src/main/js/components/ConfigDiff.js Lines 19 (patched) <https://reviews.apache.org/r/62908/#comment264767> 1. Why use `diff-before` here if the css style has applied in the wrapper of picker(divNavigation below)? 2. Is this an unimplemented css style? Perhaps we should add a legend alongside the instanceGroup picker, so that it's more intuitive to figure out the color theory. ui/src/main/js/components/JobConfig.js Lines 16 (patched) <https://reviews.apache.org/r/62908/#comment264776> UX: When there are 3 configs on the page, there is a lot of empty space on the right. Can we fill each row by 3 columns? ui/src/main/js/components/TaskConfigSummary.js Lines 55 (patched) <https://reviews.apache.org/r/62908/#comment264774> remove the `? ui/src/main/js/components/__tests__/ConfigDiff-test.js Lines 44 (patched) <https://reviews.apache.org/r/62908/#comment264770> add a space: dropdownwhen ui/src/main/js/pages/Job.js Lines 3 (patched) <https://reviews.apache.org/r/62908/#comment264777> It appers the link in the navigation Breadcrumb still points to the old scheduler ui. We should fixing the links since it's going to production. - Kai Huang On Oct. 12, 2017, 12:25 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62908/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 12:25 a.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Job page implemented in React. This is the last of the big commits before a > bug bash and other small nits than can (hopefully) be collaborated on. > > Added deep configuration diff widget (for jobs with multiple configs) but > otherwise very similar to the existing page. > > > Diffs > ----- > > ui/package.json f4532dfcb7c7b65445190a8039eca5d89b4dcd56 > ui/src/main/js/components/ConfigDiff.js PRE-CREATION > ui/src/main/js/components/JobConfig.js PRE-CREATION > ui/src/main/js/components/Pagination.js > 0aac09d7360eee1cf971b35d1874afe4fa95b0f7 > ui/src/main/js/components/Tabs.js PRE-CREATION > ui/src/main/js/components/TaskConfigSummary.js PRE-CREATION > ui/src/main/js/components/TaskList.js PRE-CREATION > ui/src/main/js/components/TaskStateMachine.js PRE-CREATION > ui/src/main/js/components/UpdateList.js > 3f57669140b04b29e12003d68ded387825e83f85 > ui/src/main/js/components/UpdatePreview.js PRE-CREATION > ui/src/main/js/components/__tests__/ConfigDiff-test.js PRE-CREATION > ui/src/main/js/components/__tests__/JobConfig-test.js PRE-CREATION > ui/src/main/js/components/__tests__/Tabs-test.js PRE-CREATION > ui/src/main/js/components/__tests__/TaskList-test.js PRE-CREATION > ui/src/main/js/index.js 30646f78a422788c5dbc07f97ca61b739a339bd9 > ui/src/main/js/pages/Job.js PRE-CREATION > ui/src/main/js/pages/__tests__/Job-test.js PRE-CREATION > ui/src/main/js/test-utils/TaskBuilders.js > 35b915217f67a712710473b5901d964f1675e4d9 > ui/src/main/js/utils/Task.js c58ff7d86af013bd977f4b114c3bffffe5f84aac > ui/src/main/sass/app.scss 315b666bd4b56b6c0c1f5b53b38a9cd61a1e4b9c > ui/src/main/sass/components/_job-page.scss PRE-CREATION > ui/src/main/sass/components/_task-list.scss PRE-CREATION > > > Diff: https://reviews.apache.org/r/62908/diff/1/ > > > Testing > ------- > > ./gradlew ui:lint > ./gradlew ui:test > > See screenshots for live API testing. > > > File Attachments > ---------------- > > Simple job - no updates > > https://reviews.apache.org/media/uploaded/files/2017/10/12/b6b53783-67d5-4cd8-a6ee-a9dc93f6f3e1__Screen_Shot_2017-10-11_at_5.16.48_PM.png > Job With Update In Progress > > https://reviews.apache.org/media/uploaded/files/2017/10/12/552bfba1-eb4d-4dfd-a21a-9d73d715230b__Screen_Shot_2017-10-11_at_5.18.29_PM.png > Configuration Tab - with diffing > > https://reviews.apache.org/media/uploaded/files/2017/10/12/6be8dc50-e231-4430-b3cf-7e383fc420bd__Screen_Shot_2017-10-11_at_5.19.25_PM.png > Multi-Config Diffing support > > https://reviews.apache.org/media/uploaded/files/2017/10/12/5bb4b753-af84-4fe1-9ce3-4110b2c96225__Screen_Shot_2017-10-11_at_5.20.15_PM.png > Expanded task item with update history too > > https://reviews.apache.org/media/uploaded/files/2017/10/12/7f2fc9e4-fa25-4b6b-ae50-afa90ac6992c__Screen_Shot_2017-10-11_at_5.20.39_PM.png > > > Thanks, > > David McLaughlin > >
