-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62908/#review187723
-----------------------------------------------------------
Master (519e3df) is red with this patch.
./build-support/jenkins/build.sh
org.apache.aurora.scheduler.http.api.ApiBetaTest > testPostInvalidStructure
FAILED
java.lang.RuntimeException
I1012 01:56:48.452 [ShutdownHook, SchedulerMain] Stopping scheduler services.
882 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated:
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle
aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
[ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is
0.65, but expected minimum is 0.79
FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 6' finished with non-zero exit value 137
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for bundle aurora: instructions covered ratio is 0.76, but
> expected minimum is 0.87
Rule violated for bundle aurora: branches covered ratio is 0.65, but expected
minimum is 0.79
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 1h 25m 3s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 12, 2017, 8:25 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62908/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 8:25 a.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Job page implemented in React. This is the last of the big commits before a
> bug bash and other small nits than can (hopefully) be collaborated on.
>
> Added deep configuration diff widget (for jobs with multiple configs) but
> otherwise very similar to the existing page.
>
>
> Diffs
> -----
>
> ui/package.json f4532dfcb7c7b65445190a8039eca5d89b4dcd56
> ui/src/main/js/components/ConfigDiff.js PRE-CREATION
> ui/src/main/js/components/JobConfig.js PRE-CREATION
> ui/src/main/js/components/Pagination.js
> 0aac09d7360eee1cf971b35d1874afe4fa95b0f7
> ui/src/main/js/components/Tabs.js PRE-CREATION
> ui/src/main/js/components/TaskConfigSummary.js PRE-CREATION
> ui/src/main/js/components/TaskList.js PRE-CREATION
> ui/src/main/js/components/TaskStateMachine.js PRE-CREATION
> ui/src/main/js/components/UpdateList.js
> 3f57669140b04b29e12003d68ded387825e83f85
> ui/src/main/js/components/UpdatePreview.js PRE-CREATION
> ui/src/main/js/components/__tests__/ConfigDiff-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/JobConfig-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/Tabs-test.js PRE-CREATION
> ui/src/main/js/components/__tests__/TaskList-test.js PRE-CREATION
> ui/src/main/js/index.js 30646f78a422788c5dbc07f97ca61b739a339bd9
> ui/src/main/js/pages/Job.js PRE-CREATION
> ui/src/main/js/pages/__tests__/Job-test.js PRE-CREATION
> ui/src/main/js/test-utils/TaskBuilders.js
> 35b915217f67a712710473b5901d964f1675e4d9
> ui/src/main/js/utils/Task.js c58ff7d86af013bd977f4b114c3bffffe5f84aac
> ui/src/main/sass/app.scss 315b666bd4b56b6c0c1f5b53b38a9cd61a1e4b9c
> ui/src/main/sass/components/_job-page.scss PRE-CREATION
> ui/src/main/sass/components/_task-list.scss PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62908/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
> See screenshots for live API testing.
>
>
> File Attachments
> ----------------
>
> Simple job - no updates
>
> https://reviews.apache.org/media/uploaded/files/2017/10/12/b6b53783-67d5-4cd8-a6ee-a9dc93f6f3e1__Screen_Shot_2017-10-11_at_5.16.48_PM.png
> Job With Update In Progress
>
> https://reviews.apache.org/media/uploaded/files/2017/10/12/552bfba1-eb4d-4dfd-a21a-9d73d715230b__Screen_Shot_2017-10-11_at_5.18.29_PM.png
> Configuration Tab - with diffing
>
> https://reviews.apache.org/media/uploaded/files/2017/10/12/6be8dc50-e231-4430-b3cf-7e383fc420bd__Screen_Shot_2017-10-11_at_5.19.25_PM.png
> Multi-Config Diffing support
>
> https://reviews.apache.org/media/uploaded/files/2017/10/12/5bb4b753-af84-4fe1-9ce3-4110b2c96225__Screen_Shot_2017-10-11_at_5.20.15_PM.png
> Expanded task item with update history too
>
> https://reviews.apache.org/media/uploaded/files/2017/10/12/7f2fc9e4-fa25-4b6b-ae50-afa90ac6992c__Screen_Shot_2017-10-11_at_5.20.39_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
