----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188254 -----------------------------------------------------------
This is great! Just some minor feedback. File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png <https://reviews.apache.org//r/63062/#fcomment114> Host Neighbors? File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot 2017-10-16 at 6.27.44 PM.png <https://reviews.apache.org//r/63062/#fcomment115> Link to instance page? ui/src/main/js/components/TaskNeighbors.js Lines 7-12 (patched) <https://reviews.apache.org/r/63062/#comment265255> const { role, environment, name } = assignedTask.task.job; const taskKey = `${role}/${environment}/${name}/${assignedTask.instanceId}` ui/src/main/js/components/__tests__/TaskNeighbors-test.js Lines 7 (patched) <https://reviews.apache.org/r/63062/#comment265256> *Should contain empty div ui/src/main/js/pages/Instance.js Lines 34 (patched) <https://reviews.apache.org/r/63062/#comment265258> Is it not possible to unit test this without mounting the component (which I still haven't been able to figure out myself)? ui/src/main/sass/components/_instance-page.scss Lines 22 (patched) <https://reviews.apache.org/r/63062/#comment265257> Remove trailing white space. - David McLaughlin On Oct. 17, 2017, 1:36 a.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63062/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 1:36 a.m.) > > > Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar > Shanmugham. > > > Repository: aurora > > > Description > ------- > > # Expose list of neighbors in the instance page > > Exposing the list of neighbor task on the host is useful when application > tail letencies degrade because of noisy neighbors. Currenlty our service > oweners need to jump to the thermos-UI to get this info. This feature will > definately help spotting misbehaving neighbors a lot easier. > > > Diffs > ----- > > ui/src/main/js/components/TaskNeighbors.js PRE-CREATION > ui/src/main/js/components/TaskStatus.js > b5149182c80b0edcdec88d5c6e24d3015409b0fc > ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION > ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5 > ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5 > ui/src/main/sass/components/_instance-page.scss > 99204fdfca4441d824c3dfff083f78e1d094b4c9 > > > Diff: https://reviews.apache.org/r/63062/diff/1/ > > > Testing > ------- > > ? ./gradlew ui:test > ? ./gradlew ui:lint > > > File Attachments > ---------------- > > Screen Shot 2017-10-16 at 6.27.44 PM.png > > https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png > > > Thanks, > > Reza Motamedi > >
