> On Oct. 17, 2017, 7:53 p.m., David McLaughlin wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > <https://reviews.apache.org/r/63062/#fcomment121> > > > > I'd also try and find a task with a longer job key and see what it does > > to the layout. It might make more sense to have this widget as a row > > spanning the whole width.
This happens when task-keys are super long. I made the `div` span the the entire column. However what I think would be better is if we push the state machine a few cells to the right. I have seen examples where the TaskId is so long that that it wraps over one line. My suggestion should help with that as well. - Reza ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188376 ----------------------------------------------------------- On Oct. 19, 2017, 10:37 p.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63062/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 10:37 p.m.) > > > Review request for Aurora, David McLaughlin, Kai Huang, and Santhosh Kumar > Shanmugham. > > > Repository: aurora > > > Description > ------- > > # Expose list of neighbors in the instance page > > Exposing the list of neighbor task on the host is useful when application > tail letencies degrade because of noisy neighbors. Currenlty our service > oweners need to jump to the thermos-UI to get this info. This feature will > definately help spotting misbehaving neighbors a lot easier. > > > Diffs > ----- > > ui/src/main/js/components/TaskNeighbors.js PRE-CREATION > ui/src/main/js/components/TaskStatus.js > b5149182c80b0edcdec88d5c6e24d3015409b0fc > ui/src/main/js/components/__tests__/TaskNeighbors-test.js PRE-CREATION > ui/src/main/js/pages/Instance.js c4d625c063b6037ae2ff93e638a3040436515cd5 > ui/src/main/js/utils/Common.js 8f2da7c8a5b44d2ded89a2070ea6ac4bf1fb6ed5 > ui/src/main/sass/components/_instance-page.scss > 99204fdfca4441d824c3dfff083f78e1d094b4c9 > > > Diff: https://reviews.apache.org/r/63062/diff/4/ > > > Testing > ------- > > ? ./gradlew ui:test > ? ./gradlew ui:lint > > > File Attachments > ---------------- > > Screen Shot 2017-10-16 at 6.27.44 PM.png > > https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png > > > Thanks, > > Reza Motamedi > >
