-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63121/#review188558
-----------------------------------------------------------
Master (b7e83a0) is red with this patch.
./build-support/jenkins/build.sh
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java:328:
Private field 'group' could be made final; it is only initialized in the
declaration or constructor.
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java:89:
Private field 'eventSink' could be made final; it is only initialized
in the declaration or constructor.
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 2 PMD rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 3m 44s
44 actionable tasks: 35 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 18, 2017, 7:40 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63121/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 7:40 p.m.)
>
>
> Review request for Aurora and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This alleviates a (slow) memory leak in static offer bans, as entries are only
> removed when an offer is removed. If a pending task group is depleted
> (either by fully scheduling the group, or terminating the job), the entry
> remains. This issue is exacerbated when offers are held for a longer
> duration,
> as is proposed in https://reviews.apache.org/r/62956/.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java
> 0637eb7f85125cf70b588d56fa7dc88130947837
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java
> e8334310a2a46a0ccb09ee6e4122c515892d3996
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java
> 2d3492d05986ef65519fd7a8c71396d055b6881f
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java
> b88d5f13889b81ba4b0171efaf6c759d23976a39
>
>
> Diff: https://reviews.apache.org/r/63121/diff/1/
>
>
> Testing
> -------
>
> This patch needs testing, and is not yet ready for submission.
>
>
> Thanks,
>
> Bill Farner
>
>
