-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63121/
-----------------------------------------------------------

(Updated Oct. 18, 2017, 5:04 p.m.)


Review request for Aurora and Jordan Ly.


Repository: aurora


Description
-------

This alleviates a (slow) memory leak in static offer bans, as entries are only
removed when an offer is removed.  If a pending task group is depleted
(either by fully scheduling the group, or terminating the job), the entry
remains.  This issue is exacerbated when offers are held for a longer duration,
as is proposed in https://reviews.apache.org/r/62956/.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
0637eb7f85125cf70b588d56fa7dc88130947837 
  src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
e8334310a2a46a0ccb09ee6e4122c515892d3996 
  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 
2d3492d05986ef65519fd7a8c71396d055b6881f 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
6e77857fcf209d3fe70fbd30cfd8484ea0414ee2 
  src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
2cfdc090ff75a63111ae146c9fe7b3542e7ac83f 
  src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 
b88d5f13889b81ba4b0171efaf6c759d23976a39 


Diff: https://reviews.apache.org/r/63121/diff/2/

Changes: https://reviews.apache.org/r/63121/diff/1-2/


Testing (updated)
-------


Thanks,

Bill Farner

Reply via email to