-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63188/#review188875
-----------------------------------------------------------
Master (7229711) is red with this patch.
./build-support/jenkins/build.sh
# [ timer expired, abort... ]
org.apache.aurora.scheduler.events.WebhookTest >
testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:203
1046 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated:
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle
aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
[ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is
0.65, but expected minimum is 0.79
FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 5' finished with non-zero exit value 134
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for bundle aurora: instructions covered ratio is 0.76, but
> expected minimum is 0.87
Rule violated for bundle aurora: branches covered ratio is 0.65, but expected
minimum is 0.79
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 13m 38s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 20, 2017, 9:48 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63188/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 9:48 p.m.)
>
>
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add filtering for the task lists on the Job page. Allows the user to filter
> by status (and at the same time, see the different statuses that their tasks
> are in across multiple pages), to search by host, instanceId or status and to
> also control whether to sort by most recent event or by instance id.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js
> 9f00a7bfd1c7a3d7b7d0b08f9a5f6d9b82d33b55
> ui/src/main/js/components/TaskList.js
> dd34c62e25f63f9b9b43076a3d5f0868d0601ee2
> ui/src/main/js/components/__tests__/JobHistory-test.js
> 13f7ecc958fa06949c1e9e4706f010a3cafb2fa7
> ui/src/main/js/components/__tests__/TaskList-test.js
> ae74ff416b836d3d3fe2c9982ff490e637b05419
> ui/src/main/sass/components/_task-list.scss
> 42b9cac9b2d45e172da65f8c20e307bb6ad8e4de
>
>
> Diff: https://reviews.apache.org/r/63188/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> No status filter when all tasks in same state
>
> https://reviews.apache.org/media/uploaded/files/2017/10/20/737b6676-7729-4e12-8c20-85004f989cb3__Screen_Shot_2017-10-20_at_2.16.32_PM.png
> Task status filter
>
> https://reviews.apache.org/media/uploaded/files/2017/10/20/1979f4ff-d6a2-424b-b1df-de91a8165dae__Screen_Shot_2017-10-20_at_2.16.43_PM.png
> No search when only one page
>
> https://reviews.apache.org/media/uploaded/files/2017/10/20/c1e280d7-6277-4f1f-b104-abf45c339840__Screen_Shot_2017-10-20_at_2.46.37_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
