> On Oct. 23, 2017, 4:50 p.m., Kai Huang wrote: > > ui/src/main/js/components/TaskList.js > > Lines 71 (patched) > > <https://reviews.apache.org/r/63188/diff/1/?file=1865006#file1865006line71> > > > > nit. It looks like the search function in the old scheduler UI is not > > prefix-based. https://aurora-smf1.twitter.biz/scheduler/aurora/devel > > > > Can we search by string.includes(substring) for slaveHost? For > > instanceId, and scheduler status, it shouldn't matter though.
Done. > On Oct. 23, 2017, 4:50 p.m., Kai Huang wrote: > > ui/src/main/js/components/TaskList.js > > Lines 103 (patched) > > <https://reviews.apache.org/r/63188/diff/1/?file=1865006#file1865006line103> > > > > nit. Can we pluralize the task.length? > > https://www.npmjs.com/package/react-pluralize Sure. That library has 3 stars on Github, so given the headache of keeping up to date with breaking changes in libraries with single maintainers (see: Reactable), I will just write a function to do the same. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63188/#review188954 ----------------------------------------------------------- On Oct. 20, 2017, 9:48 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63188/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2017, 9:48 p.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Add filtering for the task lists on the Job page. Allows the user to filter > by status (and at the same time, see the different statuses that their tasks > are in across multiple pages), to search by host, instanceId or status and to > also control whether to sort by most recent event or by instance id. > > > Diffs > ----- > > ui/src/main/js/components/JobHistory.js > 9f00a7bfd1c7a3d7b7d0b08f9a5f6d9b82d33b55 > ui/src/main/js/components/TaskList.js > dd34c62e25f63f9b9b43076a3d5f0868d0601ee2 > ui/src/main/js/components/__tests__/JobHistory-test.js > 13f7ecc958fa06949c1e9e4706f010a3cafb2fa7 > ui/src/main/js/components/__tests__/TaskList-test.js > ae74ff416b836d3d3fe2c9982ff490e637b05419 > ui/src/main/sass/components/_task-list.scss > 42b9cac9b2d45e172da65f8c20e307bb6ad8e4de > > > Diff: https://reviews.apache.org/r/63188/diff/1/ > > > Testing > ------- > > ./gradlew ui:lint > ./gradlew ui:test > > See screenshots. > > > File Attachments > ---------------- > > No status filter when all tasks in same state > > https://reviews.apache.org/media/uploaded/files/2017/10/20/737b6676-7729-4e12-8c20-85004f989cb3__Screen_Shot_2017-10-20_at_2.16.32_PM.png > Task status filter > > https://reviews.apache.org/media/uploaded/files/2017/10/20/1979f4ff-d6a2-424b-b1df-de91a8165dae__Screen_Shot_2017-10-20_at_2.16.43_PM.png > No search when only one page > > https://reviews.apache.org/media/uploaded/files/2017/10/20/c1e280d7-6277-4f1f-b104-abf45c339840__Screen_Shot_2017-10-20_at_2.46.37_PM.png > > > Thanks, > > David McLaughlin > >
