----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188979 -----------------------------------------------------------
ui/src/main/js/pages/Instance.js Line 34 (original), 38 (patched) <https://reviews.apache.org/r/63221/#comment265918> enzyme allows you to update props, you can most likely test that when you update the URL that the mock APIs are called (see apiSpy in the existing tests). ui/src/main/js/pages/Instance.js Lines 55 (patched) <https://reviews.apache.org/r/63221/#comment265917> I don't think this is related to the previous check. They should be independent if statements. ui/src/main/js/pages/Instance.js Lines 56 (patched) <https://reviews.apache.org/r/63221/#comment265919> Note that params is an object. So this is just testing for reference equality - this means you could have both false negatives and false positives here. You probably want something like the npm module "deep-equal". ui/src/main/js/pages/Instance.js Lines 58 (patched) <https://reviews.apache.org/r/63221/#comment265916> Extra initialState to a variable and use it here and in constructor? - David McLaughlin On Oct. 23, 2017, 6:01 p.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63221/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2017, 6:01 p.m.) > > > Review request for Aurora, David McLaughlin and Kai Huang. > > > Repository: aurora > > > Description > ------- > > reload instance page once a neighbor item is clicked > > > Diffs > ----- > > ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a > > > Diff: https://reviews.apache.org/r/63221/diff/1/ > > > Testing > ------- > > Checked in my vagrant and now it works. > > ``` > ? ./gradlew ui:lint > ? ./gradlew ui:test > ``` > > > Thanks, > > Reza Motamedi > >
