----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189110 -----------------------------------------------------------
ui/src/main/js/pages/Instance.js Lines 2 (patched) <https://reviews.apache.org/r/63221/#comment266031> I don't see this dependency in package.json. If the build is green, that means this code path is likely untested. Also, why did you go for lodash vs deep-equal? - David McLaughlin On Oct. 24, 2017, 12:09 a.m., Reza Motamedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63221/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 12:09 a.m.) > > > Review request for Aurora, David McLaughlin and Kai Huang. > > > Repository: aurora > > > Description > ------- > > reload instance page once a neighbor item is clicked > > > Diffs > ----- > > ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a > ui/src/main/js/pages/__tests__/Instance-test.js > 2395e2e1018d19604a76eddee15f58565f988e3a > > > Diff: https://reviews.apache.org/r/63221/diff/3/ > > > Testing > ------- > > Checked in my vagrant and now it works. > > ``` > ? ./gradlew ui:lint > ? ./gradlew ui:test > ``` > > > Thanks, > > Reza Motamedi > >
