-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/#review193477
-----------------------------------------------------------


Ship it!





build-support/jenkins/review_feedback.py
Line 178 (original), 178 (patched)
<https://reviews.apache.org/r/64508/#comment272034>

    Can you include a comment for posterity?  Referencing AURORA-1961 would be 
ideal since it holds context (should also be on the Bugs line of this review).


- Bill Farner


On Dec. 11, 2017, 1:11 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64508/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2017, 1:11 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Spotbugs prints multiple lines with \r [1][2]. This looks like a single
> line for shell commands but will be converted to multiple lines once
> read by Python.
> 
> By performing the conversion before the tail command, we will get a
> consistent line count in Bash and Python.
> 
> [1] 
> https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
> [2] https://github.com/spotbugs/spotbugs/issues/506
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/review_feedback.py 
> a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 
> 
> 
> Diff: https://reviews.apache.org/r/64508/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to