-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/
-----------------------------------------------------------

(Updated Dec. 12, 2017, 10:05 a.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1961
    https://issues.apache.org/jira/browse/AURORA-1961


Repository: aurora


Description
-------

Spotbugs prints multiple lines with \r [1][2]. This looks like a single
line for shell commands but will be converted to multiple lines once
read by Python.

By performing the conversion before the tail command, we will get a
consistent line count in Bash and Python.

[1] 
https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
[2] https://github.com/spotbugs/spotbugs/issues/506


Diffs (updated)
-----

  build-support/jenkins/review_feedback.py 
a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 


Diff: https://reviews.apache.org/r/64508/diff/2/

Changes: https://reviews.apache.org/r/64508/diff/1-2/


Testing
-------

./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu


Thanks,

Stephan Erb

Reply via email to