> On April 26, 2018, 9:38 p.m., Aurora ReviewBot wrote: > > Master (18103fe) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Pass 2: Analyzing classes (320 / 333) - 96% complete > > Pass 2: Analyzing classes (321 / 333) - 96% complete > > Pass 2: Analyzing classes (322 / 333) - 96% complete > > Pass 2: Analyzing classes (323 / 333) - 96% complete > > Pass 2: Analyzing classes (324 / 333) - 97% complete > > Pass 2: Analyzing classes (325 / 333) - 97% complete > > Pass 2: Analyzing classes (326 / 333) - 97% complete > > Pass 2: Analyzing classes (327 / 333) - 98% complete > > Pass 2: Analyzing classes (328 / 333) - 98% complete > > Pass 2: Analyzing classes (329 / 333) - 98% complete > > Pass 2: Analyzing classes (330 / 333) - 99% complete > > Pass 2: Analyzing classes (331 / 333) - 99% complete > > Pass 2: Analyzing classes (332 / 333) - 99% complete > > Pass 2: Analyzing classes (333 / 333) - 100% complete > > Done with analysis > > :test > > > > org.apache.aurora.scheduler.events.WebhookTest > > > testTaskChangedWithOldStateError FAILED > > java.lang.AssertionError at WebhookTest.java:251 > > I0426 21:37:40.001 [ShutdownHook, SchedulerMain] Stopping scheduler > > services. > > > > 1082 tests completed, 1 failed, 1 skipped > > :test FAILED > > :jacocoTestReport > > Coverage report generated: > > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html > > :jacocoTestCoverageVerification > > > > FAILURE: Build failed with an exception. > > > > * What went wrong: > > Execution failed for task ':test'. > > > There were failing tests. See the report at: > > > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html > > > > * Try: > > Run with --stacktrace option to get the stack trace. Run with --info or > > --debug option to get more log output. > > > > * Get more help at https://help.gradle.org > > > > BUILD FAILED in 6m 51s > > 45 actionable tasks: 36 executed, 9 up-to-date > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry"
@ReviewBot retry - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66806/#review202034 ----------------------------------------------------------- On April 26, 2018, 9:27 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66806/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 9:27 p.m.) > > > Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Currently Aurora exports total quota and resource reservation over time. This > can be very useful to see changes in trends of production and free tier > capacity. One challenge (particularly in a self-serve capacity environment) > is identifying and tracking where large deltas came from. This change exports > both quota and resource usage per role to help with this. > > It is possible to make this more efficient by refactoring the current > abstractions to do both totals and per-role metrics in a single pass. But > given this only runs once per hour, I went for the cleaner/simpler approach. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java > a3e9bc75d5ce48cc3d64aa6b650df708f2f7c916 > src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java > ac5cf2462cb0f383493296b541348bff40e99025 > src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java > a30d74e73774a9fd4224839d08ebfe7fb0df095a > > > Diff: https://reviews.apache.org/r/66806/diff/3/ > > > Testing > ------- > > /vars in Vagrant: > > quota_per_role_www-data_cpu_cores 10 > quota_per_role_www-data_disk_mb 102400 > quota_per_role_www-data_ram_mb 102400 > resources_allocated_quota_cpu_cores 0 > resources_allocated_quota_disk_mb 0 > resources_allocated_quota_ram_mb 0 > resources_dedicated_consumed_cpu_cores 0 > resources_dedicated_consumed_disk_mb 0 > resources_dedicated_consumed_ram_mb 0 > resources_free_pool_consumed_cpu_cores 1 > resources_free_pool_consumed_disk_mb 8 > resources_free_pool_consumed_ram_mb 1 > resources_per_role_free_pool_consumed_www-data_cpu_cores 1 > resources_per_role_free_pool_consumed_www-data_disk_mb 8 > resources_per_role_free_pool_consumed_www-data_ram_mb 1 > resources_per_role_total_consumed_www-data_cpu_cores 1 > resources_per_role_total_consumed_www-data_disk_mb 8 > resources_per_role_total_consumed_www-data_ram_mb 1 > resources_quota_consumed_cpu_cores 0 > resources_quota_consumed_disk_mb 0 > resources_quota_consumed_ram_mb 0 > resources_total_consumed_cpu_cores 1 > resources_total_consumed_disk_mb 8 > resources_total_consumed_ram_mb 1 > > > Thanks, > > David McLaughlin > >
