----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66806/#review202040 -----------------------------------------------------------
Ship it! Master (18103fe) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 26, 2018, 2:27 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66806/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 2:27 p.m.) > > > Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Currently Aurora exports total quota and resource reservation over time. This > can be very useful to see changes in trends of production and free tier > capacity. One challenge (particularly in a self-serve capacity environment) > is identifying and tracking where large deltas came from. This change exports > both quota and resource usage per role to help with this. > > It is possible to make this more efficient by refactoring the current > abstractions to do both totals and per-role metrics in a single pass. But > given this only runs once per hour, I went for the cleaner/simpler approach. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java > a3e9bc75d5ce48cc3d64aa6b650df708f2f7c916 > src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java > ac5cf2462cb0f383493296b541348bff40e99025 > src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java > a30d74e73774a9fd4224839d08ebfe7fb0df095a > > > Diff: https://reviews.apache.org/r/66806/diff/3/ > > > Testing > ------- > > /vars in Vagrant: > > quota_per_role_www-data_cpu_cores 10 > quota_per_role_www-data_disk_mb 102400 > quota_per_role_www-data_ram_mb 102400 > resources_allocated_quota_cpu_cores 0 > resources_allocated_quota_disk_mb 0 > resources_allocated_quota_ram_mb 0 > resources_dedicated_consumed_cpu_cores 0 > resources_dedicated_consumed_disk_mb 0 > resources_dedicated_consumed_ram_mb 0 > resources_free_pool_consumed_cpu_cores 1 > resources_free_pool_consumed_disk_mb 8 > resources_free_pool_consumed_ram_mb 1 > resources_per_role_free_pool_consumed_www-data_cpu_cores 1 > resources_per_role_free_pool_consumed_www-data_disk_mb 8 > resources_per_role_free_pool_consumed_www-data_ram_mb 1 > resources_per_role_total_consumed_www-data_cpu_cores 1 > resources_per_role_total_consumed_www-data_disk_mb 8 > resources_per_role_total_consumed_www-data_ram_mb 1 > resources_quota_consumed_cpu_cores 0 > resources_quota_consumed_disk_mb 0 > resources_quota_consumed_ram_mb 0 > resources_total_consumed_cpu_cores 1 > resources_total_consumed_disk_mb 8 > resources_total_consumed_ram_mb 1 > > > Thanks, > > David McLaughlin > >
