----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67219/ -----------------------------------------------------------
(Updated May 21, 2018, 6:28 p.m.) Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb. Changes ------- Updated comment. Repository: aurora Description ------- Attempt #3 at fixing the flaky Webhook test once and for all. Previously, I was testing the error condition by hitting a bad url with a port of -1. I believe this was erroneous (I am assuming the -1 overflowed into a valid port). Additionally, there was a timing associated with the test which could make it flaky as well. I ensured that the test hit a bad host url and removed the timing for a more deterministic test. Diffs (updated) ----- src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 3e10c57e00ba12725310bd50bd55743bec95a77b Diff: https://reviews.apache.org/r/67219/diff/5/ Changes: https://reviews.apache.org/r/67219/diff/4-5/ Testing ------- `./gradlew test` passes. Repeated AuroraBot tests. Thanks, Jordan Ly
