----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67219/#review203512 -----------------------------------------------------------
Ship it! Master (805a53f) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On May 21, 2018, 6:28 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67219/ > ----------------------------------------------------------- > > (Updated May 21, 2018, 6:28 p.m.) > > > Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Attempt #3 at fixing the flaky Webhook test once and for all. > > Previously, I was testing the error condition by hitting a bad url with a > port of -1. I believe this was erroneous (I am assuming the -1 overflowed > into a valid port). Additionally, there was a timing associated with the test > which could make it flaky as well. > > I ensured that the test hit a bad host url and removed the timing for a more > deterministic test. > > > Diffs > ----- > > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > 3e10c57e00ba12725310bd50bd55743bec95a77b > > > Diff: https://reviews.apache.org/r/67219/diff/5/ > > > Testing > ------- > > `./gradlew test` passes. > > Repeated AuroraBot tests. > > > Thanks, > > Jordan Ly > >
