-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204858
-----------------------------------------------------------
Ship it!
Oops missed one thing:
You need to add a scheduler active binding in the module:
```
SchedulerServicesModule.addSchedulerActiveServiceBinding(binder())
.to([SOMETHING].class);
```
- Jordan Ly
On June 15, 2018, 6:02 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 6:02 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Bugs: AURORA-1990
> https://issues.apache.org/jira/browse/AURORA-1990
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java
> 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java
> 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java
> 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
