-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/
-----------------------------------------------------------
(Updated June 15, 2018, 1:55 p.m.)
Review request for Aurora, David McLaughlin and Jordan Ly.
Changes
-------
Vagrant testing
Bugs: AURORA-1990
https://issues.apache.org/jira/browse/AURORA-1990
Repository: aurora
Description
-------
Convert SlaManager into an AbstractIdleService and explicitly
close the AsyncHttpClient on scheduler shutdown. Otherwise
we run the rise of having a stuck scheduler JVM that is unable
to shutdown due to any on the remaining non-daemon http client
threads.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java
5ad12511e3ec7dda227d133b7e0a2063c352c016
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java
98bec4857f1b3c247c24059150de3e4aac080a02
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java
07082a99701ea1e428164e76267b908ae20508ad
Diff: https://reviews.apache.org/r/67613/diff/2/
Testing (updated)
-------
./gradlew test
**Tested in vagrant:**
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.456
[BlockingDriverJoin, StateMachine] SchedulerLifecycle state machine transition
DEAD -> DEAD
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.457
[BlockingDriverJoin, SchedulerLifecycle] Shutdown already invoked, ignoring
extra call.
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.458
[TearDownShutdownRegistry STOPPING, StateMachine] storage state machine
transition READY -> STOPPED
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459
[TearDownShutdownRegistry STOPPING, Lifecycle] Shutting down application
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459
[TearDownShutdownRegistry STOPPING, ShutdownRegistry$ShutdownRegistryImpl]
Action controller has already completed, subsequent calls ignored.
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.461 [main,
SchedulerMain] Stopping scheduler services.
**Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.470
[SlaManager$$EnhancerByGuice$$40d3047 STOPPING, SlaManager] Shutting down
SlaManager async http client.**
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.475
[CronLifecycle STOPPING, CronLifecycle] Shutting down Quartz cron scheduler.
...
Jun 15 20:48:56 aurora aurora-scheduler[8719]: I0615 20:48:56.167 [main,
SchedulerMain] Application run() exited.
Thanks,
Santhosh Kumar Shanmugham
