> On June 28, 2018, 11:23 a.m., Santhosh Kumar Shanmugham wrote:
> > Can you include the end-to-end test results? This takes about an hour to 
> > complete and can be invoked like so from the project root,
> > 
> > ```
> > {~/oss/aurora} (master)$ 
> > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> > ```
> 
> Ezequiel Torres wrote:
>     I've tried to execute the e2e tests but they seem to failed even from the 
> master branch. I've uploaded the output of the test to the review. I'd really 
> appretiate if someone could give some insight about the cause of the errors 
> I'm seeing in the output.
>     
>     Kind Regards
>     Ezequiel
> 
> Santhosh Kumar Shanmugham wrote:
>     Sorry. I am not able to find the output of the test in the review. Is 
> this added as a file to the diff or in the testing section?

Unable to see the log file Ezequiel posted as well but I ran e2e tests locally 
with his patch locally and all tests passed.


- Renan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67757/#review205521
-----------------------------------------------------------


On June 27, 2018, 12:04 p.m., Ezequiel Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67757/
> -----------------------------------------------------------
> 
> (Updated June 27, 2018, 12:04 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and 
> Stephan Erb.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/AURORA-1991
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AURORA-1991
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> In languages like Go, types are not optionals by default.
> The actual api.thift don't let create queries with just a
> few fields in Go since all the fields are required
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 7265b11103aa12743c42355163ae64e98e965d7f 
> 
> 
> Diff: https://reviews.apache.org/r/67757/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ezequiel Torres
> 
>

Reply via email to