----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67757/#review205863 -----------------------------------------------------------
Ship it! Since Renan has tested it. I am okay with this change. - Santhosh Kumar Shanmugham On June 29, 2018, 4:07 p.m., Ezequiel Torres wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67757/ > ----------------------------------------------------------- > > (Updated June 29, 2018, 4:07 p.m.) > > > Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Bugs: https://issues.apache.org/jira/browse/AURORA-1991 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AURORA-1991 > > > Repository: aurora > > > Description > ------- > > In languages like Go, types are not optionals by default. > The actual api.thift don't let create queries with just a > few fields in Go since all the fields are required > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > 7265b11103aa12743c42355163ae64e98e965d7f > > > Diff: https://reviews.apache.org/r/67757/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > End2End Output - branch master > > https://reviews.apache.org/media/uploaded/files/2018/06/29/22d45287-bbce-4603-b21b-e3ddd46cb178__branch_master_end2end_test_output.txt > > > Thanks, > > Ezequiel Torres > >
