rdelval edited a comment on issue #64: update thermos_profile cmdline URL: https://github.com/apache/aurora/pull/64#issuecomment-525348424 > That makes sense to me. It has probably been around so long because people who are using the documentation know enough to quickly fix the problem and are probably too busy to submit a PR. Not sure what that says about me. :-) It says you care enough about open source to take the time to fix something :smiley: . Wish everyone that stopped by the community was like you :+1:. > > I'm not a fan of breaking the look and feel of python indentation. Unless you have an objection, I'm going to resubmit my PR with the equivalent string: > > ``` > setup_env = Process( > name="setup", > cmdline=("cat <<EOF > .thermos_profile\n" "export RESULT=hello\n" "EOF\n"), > ) > ``` > > The extraneous quotes are to make it clear where lines in the final script begin and end. If you don't care for `black` formatting, I can submit it like so: > > ``` > setup_env = Process( > name = 'setup', > cmdline = ( > 'cat <<EOF > .thermos_profile\n' > 'export RESULT=hello\n' > 'EOF\n' > ) > ) > ``` Absolutely, not a fan of breaking the indentation either and your solution looks better. The second one looks much nicer than the first :+1: One nit: can you add or remove the `$NAME` environment variable?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
