> On Jan. 15, 2014, 7:45 p.m., Jake Farrell wrote: > > This patch does not have anything to do with gpg keys, is something missing > > from the diff? also we probably want to look at moving this into a > > build-support/release/ folder since there will be several actions pre/post > > vote that have to occur for a release that we can be scripted out > > Bill Farner wrote: > The relation to keys is subtle, but is there. From git-tag's man page: > > > -u <key-id> > > Make a GPG-signed tag, using the given key > > Jon is setting it up to select the key associated with the committer > email address. > > +1 on the release subdir suggestion
+1 on moving the script there as well. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16941/#review31998 ----------------------------------------------------------- On Jan. 15, 2014, 5:50 p.m., Jonathan Boulle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16941/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 5:50 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > add support for multiple GPG keys and fix rollback instructions > > > Diffs > ----- > > build-support/tag-release 6940d5d5dadb8c68cf5268fbb5c790114de58c0a > > Diff: https://reviews.apache.org/r/16941/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Boulle > >
