----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32069 -----------------------------------------------------------
src/main/python/apache/aurora/client/commands/admin.py <https://reviews.apache.org/r/16983/#comment60766> Logic does not seem correct here. Can they both be 'falsey'? I'm probably ignorant to style here, but i'm used to 'is not None'. Is bool() interchangeable/preferable? - Bill Farner On Jan. 16, 2014, 7:59 p.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16983/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 7:59 p.m.) > > > Review request for Aurora and Jonathan Boulle. > > > Repository: aurora > > > Description > ------- > > Fix maintenance command documentation and host/filename logic. > > > Diffs > ----- > > src/main/python/apache/aurora/client/commands/admin.py > 8abb983084933f9320e782dc94f465139d559ebf > > Diff: https://reviews.apache.org/r/16983/diff/ > > > Testing > ------- > > > Thanks, > > Joe Smith > >
