----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16995/#review32389 -----------------------------------------------------------
Ship it! Ship It! - Kevin Sweeney On Jan. 20, 2014, 2:24 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16995/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2014, 2:24 p.m.) > > > Review request for Aurora, Kevin Sweeney and Suman Karumuri. > > > Bugs: AURORA-45 > https://issues.apache.org/jira/browse/AURORA-45 > > > Repository: aurora > > > Description > ------- > > I've also removed some functions from the Driver interface, since they should > be used exclusively by SchedulerLifecycle. > > No test cases were added because > SchedulerLifecycleTest#testDefeatedBeforeRegistered() triggered the issue > once expectations were altered with the desired new behavior. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/Driver.java > 5339069a0b932b4f16867335c4b5ee111169742b > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > f8b66239cc9813a032dbaf3d01109260371dee5d > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 43f0c4e6b8a75db029e8c61495326a6ab80febb6 > src/test/java/org/apache/aurora/scheduler/DriverTest.java > c3aa69c1e1bf3e301806fe20fb4d8686ca941e37 > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > ce9b3934df5406659bfa2a1fac4490df6e7d7d00 > > Diff: https://reviews.apache.org/r/16995/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > >