> On Feb. 13, 2014, 6:48 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 25 > > <https://reviews.apache.org/r/18042/diff/1/?file=483840#file483840line25> > > > > imports should be in alphabetical order.
Done. > On Feb. 13, 2014, 6:48 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 35 > > <https://reviews.apache.org/r/18042/diff/1/?file=483840#file483840line35> > > > > I'd like to see a comment that explains what an SLA vector *is*. Done. > On Feb. 13, 2014, 6:48 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/sla.py, line 47 > > <https://reviews.apache.org/r/18042/diff/1/?file=483843#file483843line47> > > > > At least in client, we've been trying to just do 4-column indents, not > > indent-to-open-paren. Not sure how it got that far. Fixed. > On Feb. 13, 2014, 6:48 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/sla.py, line 51 > > <https://reviews.apache.org/r/18042/diff/1/?file=483843#file483843line51> > > > > @classmethod or @staticmethod, since it doesn't need self? Sure. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34393 ----------------------------------------------------------- On Feb. 13, 2014, 12:01 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18042/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 12:01 a.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-206 > https://issues.apache.org/jira/browse/AURORA-206 > > > Repository: aurora > > > Description > ------- > > Implementing api and cli logic for the get_task_up_count command. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/BUILD > 69229a87698ed7e99957cd74364bb2ed6b93c6a3 > src/main/python/apache/aurora/client/api/__init__.py > 8bc05e20e34aa3266c2a9c5f24a1cfec8adaf24d > src/main/python/apache/aurora/client/api/sla.py PRE-CREATION > src/main/python/apache/aurora/client/cli/BUILD > f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 > src/main/python/apache/aurora/client/cli/client.py > e416d3879cc5943ec5ab3931a8b1aedb85a379a9 > src/main/python/apache/aurora/client/cli/sla.py PRE-CREATION > src/test/python/apache/aurora/client/api/BUILD > 9833535bd6a25d6409abe584056152e1ac84548e > src/test/python/apache/aurora/client/api/test_sla.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > c106b97a0902da5cd791b18117da3198bfb43b8c > src/test/python/apache/aurora/client/cli/test_sla.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18042/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client:all > > > Thanks, > > Maxim Khutornenko > >
