----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34421 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/sla.py <https://reviews.apache.org/r/18042/#comment64517> Done. I was following java guidelines though where we have a \n any time a line overflows like that. src/main/python/apache/aurora/client/cli/sla.py <https://reviews.apache.org/r/18042/#comment64519> Ah, thanks, hated that str() conversion. src/main/python/apache/aurora/client/cli/sla.py <https://reviews.apache.org/r/18042/#comment64529> Great suggestion. I am skipping the short option idea as it's not being used anywhere in the new cli. Going with a comma-separated list of durations instead. src/main/python/apache/aurora/client/cli/sla.py <https://reviews.apache.org/r/18042/#comment64530> Done. - Maxim Khutornenko On Feb. 13, 2014, 7:25 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18042/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 7:25 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-206 > https://issues.apache.org/jira/browse/AURORA-206 > > > Repository: aurora > > > Description > ------- > > Implementing api and cli logic for the get_task_up_count command. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/BUILD > 69229a87698ed7e99957cd74364bb2ed6b93c6a3 > src/main/python/apache/aurora/client/api/__init__.py > 8bc05e20e34aa3266c2a9c5f24a1cfec8adaf24d > src/main/python/apache/aurora/client/api/sla.py PRE-CREATION > src/main/python/apache/aurora/client/cli/BUILD > f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 > src/main/python/apache/aurora/client/cli/client.py > e416d3879cc5943ec5ab3931a8b1aedb85a379a9 > src/main/python/apache/aurora/client/cli/sla.py PRE-CREATION > src/test/python/apache/aurora/client/api/BUILD > 9833535bd6a25d6409abe584056152e1ac84548e > src/test/python/apache/aurora/client/api/test_sla.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > c106b97a0902da5cd791b18117da3198bfb43b8c > src/test/python/apache/aurora/client/cli/test_sla.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18042/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client:all > > > Thanks, > > Maxim Khutornenko > >
