> On Feb. 18, 2014, 8:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/sla.py, lines 61-62 > > <https://reviews.apache.org/r/18153/diff/2/?file=496733#file496733line61> > > > > This is handled in the return statement by validating the index range. > > Having max() would not hurt though. Added.
except the semantics are different: the previous way would return 0 instead of return array[0] which is correct. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/#review34775 ----------------------------------------------------------- On Feb. 18, 2014, 8:46 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18153/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 8:46 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-207 > https://issues.apache.org/jira/browse/AURORA-207 > > > Repository: aurora > > > Description > ------- > > Added "sla get_job_uptime" command. > > Also, changed from ValueError to ArgumentTypeError in options.py as the > former is not handled properly by argparser and no custom messages were > reported. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/sla.py > b69d20818836fb6ae87b333e33008b27e013954f > src/main/python/apache/aurora/client/cli/options.py > 37f416d563b526cccf3c9cab69a5df15873db250 > src/main/python/apache/aurora/client/cli/sla.py > a3973df870567052083b1d5a524438191eb6d812 > src/test/python/apache/aurora/client/api/test_sla.py > 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 > src/test/python/apache/aurora/client/cli/test_sla.py > 703d39e4566a30900f1e9bcca5871c4a426cc6c3 > > Diff: https://reviews.apache.org/r/18153/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Maxim Khutornenko > >
