----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/ -----------------------------------------------------------
(Updated Feb. 25, 2014, 9:33 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-135 https://issues.apache.org/jira/browse/AURORA-135 Repository: aurora Description ------- I've also done some tidying of the storage interfaces here, which make code simpler in several places: - Introduced LockType in ReadWriteLockManager to make parameterized lock/unlock possible - Introduced StorageOperation as a base interface for Work and MutateWork. - Moved Storage#snapshot() to NonVolatileStorage Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java a02991453def78bbf6a00c8946d2079fdc4539e9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 9cc1d1e871bc34fd244565a692215b9657e164a8 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java fd1be9f4e31aaebb724ad69d7ddb925fd30aee21 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 30d77cc86fba569cfaa35ae69d97726072660aed src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e6a32b8ed8f42a8ce7c4ffe43a796fd0cac5eacc src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 5dc7df18325f9a637ef9009197555e8d53c3b498 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 1f02e84f8f2e78b47ccbb41a56f95ea87b5882e5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f0f0e39c40758cd40c981bcbde1e59f2e7a99e3f src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d Diff: https://reviews.apache.org/r/18240/diff/ Testing ------- ./gradlew build Thanks, Bill Farner