----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38903 -----------------------------------------------------------
Ship it! src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java <https://reviews.apache.org/r/19709/#comment71239> Linking to itself seems redundant here and might be confusing. Suggest using @code instead. src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java <https://reviews.apache.org/r/19709/#comment71237> Drop newline - Maxim Khutornenko On March 28, 2014, 1:02 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19709/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 1:02 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-132 > https://issues.apache.org/jira/browse/AURORA-132 > > > Repository: aurora > > > Description > ------- > > crontab(5) entry parser. > > > Diffs > ----- > > build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19709/diff/ > > > Testing > ------- > > ./gradlew build > > Removed a few test cases from valid-cron-schedules.json after inspection > revealed they should be considered invalid. > > > Thanks, > > Kevin Sweeney > >
