> On March 27, 2014, 2:54 p.m., Bill Farner wrote: > > build.gradle, line 223 > > <https://reviews.apache.org/r/19709/diff/2/?file=538968#file538968line223> > > > > Please exclude junit-dep instead.
Done. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38821 ----------------------------------------------------------- On March 27, 2014, 2:52 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19709/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 2:52 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-132 > https://issues.apache.org/jira/browse/AURORA-132 > > > Repository: aurora > > > Description > ------- > > Cron scheduler based on Quartz. > > Apologies for the monster diff - I will try to split it but wanted to give > y'all a chance to take a look in the evening/morning. > > I'd suggest reviewing CrontabEntry and CrontabEntryTest for now - the rest is > plumbing. > > > Diffs > ----- > > build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java > PRE-CREATION > > src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json > dced8b454c97b9c456605144161ff5c946cb384f > > Diff: https://reviews.apache.org/r/19709/diff/ > > > Testing > ------- > > ./gradlew build > > Removed a few test cases from valid-cron-schedules.json after inspection > revealed they should be considered invalid. > > > Thanks, > > Kevin Sweeney > >
