----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20377/#review40478 -----------------------------------------------------------
Thoughts on moving all the repeated calls in each BUILD file to ./pants and exporting as an env var? build.gradle looks fine, only issue is that source releases typically will not have .git included with them so we can not use git describe for the source release. Should change so that if git describe fails then it falls through to .auroraversion - Jake Farrell On April 15, 2014, 9:23 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20377/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 9:23 p.m.) > > > Review request for Aurora, Jake Farrell and Bill Farner. > > > Bugs: AURORA-320 > https://issues.apache.org/jira/browse/AURORA-320 > > > Repository: aurora > > > Description > ------- > > Use git-describe to generate version number instead of .auroraversion. > > > Diffs > ----- > > build.gradle ea488414d366ece89ba25e42b98f6ad7ddbf3378 > src/main/python/apache/aurora/client/BUILD > 118c4a080b2aac88f1fb6365787b3bb55a665bea > src/main/python/apache/aurora/common/BUILD > 4646c05972b678371e9b030e042b8899568b8374 > src/main/python/apache/aurora/config/BUILD > d7467280843e3c5f9f16e46258a12b07b7b99f49 > src/main/python/apache/aurora/executor/BUILD > 9f0cad0244c46d3175b492f65b37e1cb0619aa34 > src/main/python/apache/thermos/BUILD > 19b242dba75017e57a25def26530fffcf0c758a6 > src/main/python/apache/thermos/common/BUILD > a256f2e015c2984adc8aa34c3a7e99a50a978083 > src/main/python/apache/thermos/config/BUILD > b0806057db4d221467a29ff5c2761113e7b1030c > src/main/python/apache/thermos/core/BUILD > 77bd289cdfe8ffa17a011e7d4d8debe44d45310a > src/main/python/apache/thermos/monitoring/BUILD > 448baadf641bf44d28e91b4d0c5f6303f4ae62e7 > src/main/python/apache/thermos/observer/BUILD > 79168825d1fd5660a01a8b229a765149bc84b358 > src/main/thrift/org/apache/aurora/gen/BUILD > dce379cedc0fe025e59dbed6186f650a58bc42c2 > src/main/thrift/org/apache/thermos/BUILD > 2765575b3c29cfed4dea64e0132443a9874ce83c > > Diff: https://reviews.apache.org/r/20377/diff/ > > > Testing > ------- > > ./gradlew assemble > => dist/libs/aurora-0.3.0-209-g31ec70b.jar > > ./build-support/release/make-python-sdists > => dist/apache.aurora.client-0.3.0-209-g31ec70b.tar.gz > > echo 'also marks dirty' >> DISCLAIMER > > ./gradlew assemble > => dist/libs/aurora-0.3.0-209-g31ec70b-dirty.jar > > ./build-support/release/make-python-sdists > => dist/apache.aurora.client-0.3.0-209-g31ec70b-dirty.tar.gz > > > Thanks, > > Kevin Sweeney > >
