> On April 16, 2014, 12:56 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java, line 
> > 177
> > <https://reviews.apache.org/r/20425/diff/1/?file=561192#file561192line177>
> >
> >     Would it rather make sense to use a timed wait instead?
> >     
> > http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/Service.html#awaitTerminated(long,
> >  java.util.concurrent.TimeUnit)

I think it might make sense to punt that to a global max timeout (with 
AURORA-324). As it stands the cron scheduler has no state to persist so it's 
questionable that it should even get a shutdown signal.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20425/#review40597
-----------------------------------------------------------


On April 16, 2014, 12:52 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20425/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 12:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-325
>     https://issues.apache.org/jira/browse/AURORA-325
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Shutdown cron asynchronously
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 
> fa39e2b901bdc764d802a05d26ee73d77ef7604d 
> 
> Diff: https://reviews.apache.org/r/20425/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to