----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21136/#review42370 -----------------------------------------------------------
src/.isort.cfg <https://reviews.apache.org/r/21136/#comment76149> can this live in config/ instead? that's where java checkstyle stuff lives - Kevin Sweeney On May 6, 2014, 4:10 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21136/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 4:10 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-149 > https://issues.apache.org/jira/browse/AURORA-149 > > > Repository: aurora > > > Description > ------- > > Adds build-support/isort wrapper for isort. > Adds build-support/isort-run to run import sort, build-support/isort-check to > run import order check. > Adds build-support/hooks which contains hooks that people can place into > their .git/hooks directory, currently just a pre-commit hook that checks > import sort order (which can be overridden with an environment variable.) > > The ordering it produces is different than the one we currently have but > closer to straight PEP8. If it runs, it's about a 500 line diff which I can > send later. > > > Diffs > ----- > > build-support/hooks/pre-commit PRE-CREATION > build-support/isort PRE-CREATION > build-support/isort-check PRE-CREATION > build-support/isort-run PRE-CREATION > src/.isort.cfg PRE-CREATION > > Diff: https://reviews.apache.org/r/21136/diff/ > > > Testing > ------- > > Ran the isort and ran tests, everything worked. > > > Thanks, > > Brian Wickman > >
