> On May 13, 2014, 9:15 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java, line 60 > > <https://reviews.apache.org/r/21349/diff/1/?file=579254#file579254line60> > > > > Should have caught this before, but this should be named _interval > > rather than _rate
Changed. > On May 13, 2014, 9:15 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java, line 99 > > <https://reviews.apache.org/r/21349/diff/1/?file=579254#file579254line99> > > > > This begs for test coverage. Otherwise the bug fix doesn't hold much > > water. Thanks for pushing back. Moved SlaModule() instantiation into SchedulerMain to make it testable in SchedulerIT. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21349/#review42886 ----------------------------------------------------------- On May 12, 2014, 10:58 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21349/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 10:58 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-410 > https://issues.apache.org/jira/browse/AURORA-410 > > > Repository: aurora > > > Description > ------- > > Starting SLA calculations on SchedulerActive event. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java > bc900304ac6416442ae15be77fa997d8a18e7648 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 8a0707ec2dfb695847d93a6e60adbbb488c22195 > > Diff: https://reviews.apache.org/r/21349/diff/ > > > Testing > ------- > > gradle build > gradle run > > > Thanks, > > Maxim Khutornenko > >
