> On May 15, 2014, 12:09 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 97 > > <https://reviews.apache.org/r/21349/diff/3/?file=581963#file581963line97> > > > > It would be nice to change this to Amount<Long, Time> to make it harder > > to misuse. It also improves readability at your test call site: > > > > new SlaModule(5L) > > > > becomes > > > > new SlaModule(Amount.of(5L, Time.MILLISECONDS))
Sure, fine with me. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21349/#review43055 ----------------------------------------------------------- On May 14, 2014, 9:58 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21349/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 9:58 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-410 > https://issues.apache.org/jira/browse/AURORA-410 > > > Repository: aurora > > > Description > ------- > > Starting SLA calculations on SchedulerActive event. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java > 13449ccae12bd906a4d948f4b4a83cf755eeca77 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 8a0707ec2dfb695847d93a6e60adbbb488c22195 > src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/21349/diff/ > > > Testing > ------- > > gradle build > gradle run > > > Thanks, > > Maxim Khutornenko > >
