-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21383/#review43012
-----------------------------------------------------------


Heads up: this has high likelihood of conflicting with 
https://reviews.apache.org/r/19767, which was reverted and needs to go back in 
soon.  I'm going to wager that the merge conflict is easier to deal with on 
this end, so i'm going to hold on this review for a day or so to give that 
review a chance to pick back up.

- Bill Farner


On May 14, 2014, 2:39 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21383/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 2:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: aurora-417
>     https://issues.apache.org/jira/browse/aurora-417
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add cron schedule and deschedule calls to the scheduler API.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 226b71ce7749492abd3e1d673382668c9011a1c8 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> f33059904fb5f6fc18a3a66dfe63c059008affe3 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  9bb5c255e1118038b953fc72f0a074d461ba1fb5 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 66292dc0369941fc62719d49209edc07adc81a53 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  da6c0ff1bdfaefef2f72ad2559f4059cd44612b6 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 933a56bf3f7165fa84aedcc8d1392e32824fd487 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 399d4c614dda93ae0e7d8f38a02379bc0f42e4af 
> 
> Diff: https://reviews.apache.org/r/21383/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests with gradlew; no errors. (Includes two new tests, that ensure 
> that calling the new APIs causes the right internal cron methods to be 
> called.)
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to