-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21383/
-----------------------------------------------------------
(Updated May 19, 2014, 8:25 p.m.)
Review request for Aurora, David McLaughlin and Bill Farner.
Changes
-------
Address Bill's review:
- Some style fixes
- Move new method bodies from CoreSchedulerImpl to SchedulerThriftInterface.
- Fix method documentation.
- Add a test of failed descheduling.
Bugs: aurora-417
https://issues.apache.org/jira/browse/aurora-417
Repository: aurora
Description
-------
Add cron schedule and deschedule calls to the scheduler API.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
4386a86c0aebdb9666c0232672f8c1bab7458f47
src/main/thrift/org/apache/aurora/gen/api.thrift
66292dc0369941fc62719d49209edc07adc81a53
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
2142f116afffdbd9acb63b835c240f03f417c511
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java
933a56bf3f7165fa84aedcc8d1392e32824fd487
src/test/python/apache/aurora/client/api/test_scheduler_client.py
399d4c614dda93ae0e7d8f38a02379bc0f42e4af
Diff: https://reviews.apache.org/r/21383/diff/
Testing
-------
Ran all tests with gradlew; no errors. (Includes two new tests, that ensure
that calling the new APIs causes the right internal cron methods to be called.)
Thanks,
Mark Chu-Carroll
