----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21497/#review43155 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java <https://reviews.apache.org/r/21497/#comment77200> Please either add an additional flag that allows you to set the origin, or just modify this flag to accept that value. i.e. --enable_cors_for="*" - David McLaughlin On May 15, 2014, 7:28 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21497/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 7:28 p.m.) > > > Review request for Aurora, David McLaughlin and Kevin Sweeney. > > > Bugs: AURORA-390 > https://issues.apache.org/jira/browse/AURORA-390 > > > Repository: aurora > > > Description > ------- > > Add CORS support for thrift end points. Added a command line option to > explicitly enable that support since this may a potential security issue and > we may not want to enable it in production. > > > Diffs > ----- > > build.gradle 09fe3bfc5ec535c6bdc8efeb87b0c7e3baf123c5 > src/main/java/org/apache/aurora/scheduler/thrift/CorsFilter.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > fc5610ec4483bf236da39cb31c0756934b6d264f > > Diff: https://reviews.apache.org/r/21497/diff/ > > > Testing > ------- > > Local laptop. Attached screenshot. > Called the API from another JS app and was able to make a successful > $http.post(). > > > File Attachments > ---------------- > > Screenshot with CORS flags > > https://reviews.apache.org/media/uploaded/files/2014/05/15/fbf1bc72-3b9c-4b6f-a1e1-401d00cb07f7__Screen_Shot_2014-05-15_at_12.27.23_PM.png > > > Thanks, > > Suman Karumuri > >
