> On May 16, 2014, 6:48 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, line 126
> > <https://reviews.apache.org/r/21497/diff/2/?file=582823#file582823line126>
> >
> >     Push this flag into ThriftModule

Done.


> On May 16, 2014, 6:48 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/CorsFilter.java, line 39
> > <https://reviews.apache.org/r/21497/diff/2/?file=582824#file582824line39>
> >
> >     Link to documentation for allowable formats and/or selected examples?

Done. Added a link to documentation instead of examples since working examples 
are a moving target wrt to browser support.


> On May 16, 2014, 6:48 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/CorsFilter.java, line 46
> > <https://reviews.apache.org/r/21497/diff/2/?file=582824#file582824line46>
> >
> >     camelCase. did this pass checkstyle?

Not sure how this passed my checkstyle. Fixed now.


> On May 16, 2014, 6:48 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 39
> > <https://reviews.apache.org/r/21497/diff/2/?file=582825#file582825line39>
> >
> >     kill this constructor and push the commandline flag into the Module.

Done.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/#review43234
-----------------------------------------------------------


On May 16, 2014, 12:16 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21497/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 12:16 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-390
>     https://issues.apache.org/jira/browse/AURORA-390
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add CORS support for thrift end points. Added a command line option to 
> explicitly enable that support since this may a potential security issue and 
> we may not want to enable it in production.
> 
> 
> Diffs
> -----
> 
>   build.gradle 09fe3bfc5ec535c6bdc8efeb87b0c7e3baf123c5 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> da6f5e5cfe716ca74bceab2ef5b52ec468d73ea2 
>   src/main/java/org/apache/aurora/scheduler/thrift/CorsFilter.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
> fc5610ec4483bf236da39cb31c0756934b6d264f 
> 
> Diff: https://reviews.apache.org/r/21497/diff/
> 
> 
> Testing
> -------
> 
> Local laptop. Attached screenshot.
> Called the API from another JS app and was able to make a successful 
> $http.post().
> 
> 
> File Attachments
> ----------------
> 
> cors with whitelisted domains
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/16/c4cc2abd-3c3f-4b84-ba8e-c2a353815c56__Screen_Shot_2014-05-15_at_5.11.01_PM.png
> disabled cors.
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/16/2d3a938f-c10c-4f17-9ead-326a6748dc49__Screen_Shot_2014-05-15_at_5.10.36_PM.png
> cors with default whitelist.
>   
> https://reviews.apache.org/media/uploaded/files/2014/05/16/5af2094a-b015-42c6-a802-7ad016d06480__Screen_Shot_2014-05-15_at_5.12.06_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to